kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ERR: Using strncpy instead of snprintf for portability.

This commit is contained in:
Brad King 2003-07-09 16:18:14 -04:00
parent d0964a349e
commit 36880845b6
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Source/kwsys/ProcessUNIX.c
View File

@ -526,8 +526,7 @@ int kwsysProcess_WaitForData(kwsysProcess* cp, int pipes, char** data, int* leng
{ {
/* Select returned an error. Leave the error description in the /* Select returned an error. Leave the error description in the
pipe buffer. */ pipe buffer. */
snprintf(cp->ErrorMessage, KWSYSPE_PIPE_BUFFER_SIZE, strncpy(cp->ErrorMessage, strerror(errno), KWSYSPE_PIPE_BUFFER_SIZE);
"%s", strerror(errno));
/* Kill the child now. */ /* Kill the child now. */
kwsysProcess_Kill(cp); kwsysProcess_Kill(cp);
@ -730,7 +729,7 @@ static void kwsysProcessCleanup(kwsysProcess* cp, int error)
/* If cleaning up due to an error, report the error message. */ /* If cleaning up due to an error, report the error message. */
if(error) if(error)
{ {
snprintf(cp->ErrorMessage, KWSYSPE_PIPE_BUFFER_SIZE, "%s", strerror(errno)); strncpy(cp->ErrorMessage, strerror(errno), KWSYSPE_PIPE_BUFFER_SIZE);
cp->State = kwsysProcess_State_Error; cp->State = kwsysProcess_State_Error;
} }
@ -887,7 +886,7 @@ static void kwsysProcessChildErrorExit(kwsysProcess* cp)
{ {
/* Construct the error message. */ /* Construct the error message. */
char buffer[KWSYSPE_PIPE_BUFFER_SIZE]; char buffer[KWSYSPE_PIPE_BUFFER_SIZE];
snprintf(buffer, KWSYSPE_PIPE_BUFFER_SIZE, "%s", strerror(errno)); strncpy(buffer, strerror(errno), KWSYSPE_PIPE_BUFFER_SIZE);
/* Report the error to the parent through the special pipe. */ /* Report the error to the parent through the special pipe. */
write(cp->PipeWriteEnds[KWSYSPE_PIPE_ERROR], buffer, strlen(buffer)); write(cp->PipeWriteEnds[KWSYSPE_PIPE_ERROR], buffer, strlen(buffer));