kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cmMacroCommand: Declare arg in the scope that it is used. 

It can make sense to declare objects outside of loops if
the size required by the object can grow (eg std::string when
using getline), but that is not the case here.
This commit is contained in:
Stephen Kelly 2015-02-11 20:23:36 +01:00
parent a551851ab3
commit 2c4a7298fc
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Source/cmMacroCommand.cxx
View File

@ -85,7 +85,6 @@ bool cmMacroHelperCommand::InvokeInitialPass
this->Makefile->ExpandArguments(args, expandedArgs); this->Makefile->ExpandArguments(args, expandedArgs);
std::string tmps; std::string tmps;
cmListFileArgument arg;
// make sure the number of arguments passed is at least the number // make sure the number of arguments passed is at least the number
// required by the signature // required by the signature
@ -144,6 +143,8 @@ bool cmMacroHelperCommand::InvokeInitialPass
// Set the FilePath on the arguments to match the function since it is // Set the FilePath on the arguments to match the function since it is
// not stored and the original values may be freed // not stored and the original values may be freed
k->FilePath = this->FilePath.c_str(); k->FilePath = this->FilePath.c_str();
cmListFileArgument arg;
if(k->Delim == cmListFileArgument::Bracket) if(k->Delim == cmListFileArgument::Bracket)
{ {
arg.Value = k->Value; arg.Value = k->Value;