Merge topic 'include-what-you-use'

a2af850b fix a batch of include-what-you-use violations

Source/CursesDialog/cmCursesCacheEntryComposite.h

@@ -14,6 +14,8 @@
 
 #include "cmCursesLabelWidget.h"
 
+class cmake;
+
 class cmCursesCacheEntryComposite
 {
 public:

Source/cmCacheManager.h

@@ -17,6 +17,7 @@
 #include "cmPropertyMap.h"
 #include "cmState.h"
 
+class cmake;
 class cmMarkAsAdvancedCommand;
 
 /** \class cmCacheManager

Source/cmGhsMultiTargetGenerator.h

@@ -16,13 +16,13 @@
 
 #include "cmTarget.h"
 
+class cmCustomCommand;
 class cmGeneratedFileStream;
+class cmGeneratorTarget;
 class cmGlobalGhsMultiGenerator;
 class cmLocalGhsMultiGenerator;
 class cmMakefile;
 class cmSourceFile;
-class cmGeneratedFileStream;
-class cmCustomCommand;
 
 class cmGhsMultiTargetGenerator
 {

Source/cmState.cxx

@@ -15,10 +15,19 @@
 #include "cmCacheManager.h"
 #include "cmCommand.h"
 #include "cmDefinitions.h"
+#include "cmListFileCache.h"
+#include "cmSystemTools.h"
+#include "cmTypeMacro.h"
 #include "cmVersion.h"
 #include "cmake.h"
 
+#include <algorithm>
 #include <assert.h>
+#include <cmsys/RegularExpression.hxx>
+#include <iterator>
+#include <stdio.h>
+#include <string.h>
+#include <utility>
 
 struct cmState::SnapshotDataType
 {

Source/cmState.h

@@ -12,19 +12,25 @@
 #ifndef cmState_h
 #define cmState_h
 
-#include "cmStandardIncludes.h"
+#include <cmConfigure.h> // IWYU pragma: keep
 
 #include "cmAlgorithms.h"
+#include "cmDefinitions.h"
 #include "cmLinkedTree.h"
 #include "cmPolicies.h"
+#include "cmProperty.h"
 #include "cmPropertyDefinitionMap.h"
 #include "cmPropertyMap.h"
 
-class cmake;
+#include <map>
-class cmCommand;
+#include <set>
-class cmDefinitions;
+#include <string>
-class cmListFileBacktrace;
+#include <vector>
+
 class cmCacheManager;
+class cmCommand;
+class cmListFileBacktrace;
+class cmPropertyDefinition;
 
 class cmState
 {

Source/cmSystemTools.h

@@ -12,10 +12,13 @@
 #ifndef cmSystemTools_h
 #define cmSystemTools_h
 
-#include "cmStandardIncludes.h"
+#include <cmConfigure.h> // IWYU pragma: keep
 
 #include <cmsys/Process.h>
 #include <cmsys/SystemTools.hxx>
+#include <stddef.h>
+#include <string>
+#include <vector>
 
 class cmSystemToolsFileTime;
 

Source/cmTarget.cxx

@@ -12,21 +12,25 @@
 #include "cmTarget.h"
 
 #include "cmAlgorithms.h"
-#include "cmComputeLinkInformation.h"
 #include "cmGeneratorExpression.h"
-#include "cmGeneratorExpressionDAGChecker.h"
+#include "cmGeneratorTarget.h"
 #include "cmGlobalGenerator.h"
 #include "cmListFileCache.h"
 #include "cmMakefile.h"
 #include "cmOutputConverter.h"
+#include "cmProperty.h"
 #include "cmSourceFile.h"
+#include "cmSourceFileLocation.h"
+#include "cmSystemTools.h"
 #include "cmake.h"
+
+#include <algorithm>
 #include <assert.h>
 #include <cmsys/RegularExpression.hxx>
-#include <errno.h>
 #include <map>
 #include <set>
-#include <stdlib.h> // required for atof
+#include <sstream>
+#include <string.h>
 
 #if defined(CMake_HAVE_CXX_UNORDERED_SET)
 #include <unordered_set>

Source/cmTarget.h

@@ -12,14 +12,23 @@
 #ifndef cmTarget_h
 #define cmTarget_h
 
-#include "cmStandardIncludes.h"
+#include <cmConfigure.h> // IWYU pragma: keep
 
+#include "cmAlgorithms.h"
 #include "cmCustomCommand.h"
 #include "cmListFileCache.h"
 #include "cmPolicies.h"
 #include "cmPropertyMap.h"
+#include "cmState.h"
+#include "cmTargetLinkLibraryType.h"
+
+#include <iosfwd>
+#include <map>
+#include <set>
+#include <string>
+#include <utility>
+#include <vector>
 
-#include <cm_auto_ptr.hxx>
 #if defined(CMAKE_BUILD_WITH_CMAKE)
 #ifdef CMake_HAVE_CXX_UNORDERED_MAP
 #include <unordered_map>
@@ -28,16 +37,10 @@
 #endif
 #endif
 
-class cmake;
 class cmMakefile;
 class cmSourceFile;
-class cmGlobalGenerator;
-class cmListFileBacktrace;
-class cmTarget;
-class cmGeneratorTarget;
-class cmTargetTraceDependencies;
-
 class cmTargetInternals;
+
 class cmTargetInternalPointer
 {
 public:

Source/cmTest.cxx

@@ -11,10 +11,10 @@
 ============================================================================*/
 #include "cmTest.h"
 
-#include "cmSystemTools.h"
-
 #include "cmMakefile.h"
-#include "cmake.h"
+#include "cmProperty.h"
+#include "cmState.h"
+#include "cmSystemTools.h"
 
 cmTest::cmTest(cmMakefile* mf)
   : Backtrace(mf->GetBacktrace())

Source/cmTest.h

@@ -12,11 +12,14 @@
 #ifndef cmTest_h
 #define cmTest_h
 
-#include "cmStandardIncludes.h"
+#include <cmConfigure.h> // IWYU pragma: keep
 
-#include "cmCustomCommand.h"
 #include "cmListFileCache.h"
 #include "cmPropertyMap.h"
+
+#include <string>
+#include <vector>
+
 class cmMakefile;
 
 /** \class cmTest

Source/cmTestGenerator.cxx

@@ -12,11 +12,19 @@
 #include "cmTestGenerator.h"
 
 #include "cmGeneratorExpression.h"
+#include "cmGeneratorTarget.h"
 #include "cmLocalGenerator.h"
 #include "cmOutputConverter.h"
+#include "cmProperty.h"
+#include "cmPropertyMap.h"
+#include "cmState.h"
 #include "cmSystemTools.h"
 #include "cmTest.h"
 
+#include <map>
+#include <ostream>
+#include <utility>
+
 cmTestGenerator::cmTestGenerator(
   cmTest* test, std::vector<std::string> const& configurations)
   : cmScriptGenerator("CTEST_CONFIGURATION_TYPE", configurations)

Source/cmTestGenerator.h

@@ -12,10 +12,16 @@
 #ifndef cmTestGenerator_h
 #define cmTestGenerator_h
 
+#include <cmConfigure.h> // IWYU pragma: keep
+
 #include "cmScriptGenerator.h"
 
-class cmTest;
+#include <iosfwd>
+#include <string>
+#include <vector>
+
 class cmLocalGenerator;
+class cmTest;
 
 /** \class cmTestGenerator
  * \brief Support class for generating install scripts.

Source/cmUuid.cxx

@@ -11,10 +11,10 @@
 ============================================================================*/
 #include "cmUuid.h"
 
-#include <string.h>
-
 #include "cm_sha2.h"
+
 #include <cmsys/MD5.h>
+#include <string.h>
 
 cmUuid::cmUuid()
 {

Source/cmUuid.h

@@ -12,7 +12,10 @@
 #ifndef cmUuid_h
 #define cmUuid_h
 
-#include "cmStandardIncludes.h"
+#include <cmConfigure.h> // IWYU pragma: keep
+
+#include <string>
+#include <vector>
 
 /** \class cmUuid
  * \brief Utility class to generate UUIDs as defined by RFC4122

Source/cmVariableWatch.cxx

@@ -13,7 +13,9 @@
 
 #include "cmAlgorithms.h"
 
+#include <algorithm>
 #include <cm_auto_ptr.hxx>
+#include <utility>
 
 static const char* const cmVariableWatchAccessStrings[] = {
   "READ_ACCESS",     "UNKNOWN_READ_ACCESS", "UNKNOWN_DEFINED_ACCESS",

Source/cmVariableWatch.h

@@ -12,7 +12,11 @@
 #ifndef cmVariableWatch_h
 #define cmVariableWatch_h
 
-#include "cmStandardIncludes.h"
+#include <cmConfigure.h> // IWYU pragma: keep
+
+#include <map>
+#include <string>
+#include <vector>
 
 class cmMakefile;
 

Source/cmVersion.cxx

@@ -11,7 +11,7 @@
 ============================================================================*/
 #include "cmVersion.h"
 
-#include "cmVersionMacros.h"
+#include "cmVersionConfig.h"
 
 unsigned int cmVersion::GetMajorVersion()
 {

Source/cmVersion.h

@@ -12,7 +12,7 @@
 #ifndef cmVersion_h
 #define cmVersion_h
 
-#include "cmStandardIncludes.h"
+#include <cm_kwiml.h>
 
 /** \class cmVersion
  * \brief Helper class for providing CMake and CTest version information.

Source/cmXMLParser.cxx

@@ -11,10 +11,12 @@
 ============================================================================*/
 #include "cmXMLParser.h"
 
-#include <cmsys/FStream.hxx>
-
 #include <cm_expat.h>
+#include <cmsys/FStream.hxx>
 #include <ctype.h>
+#include <iostream>
+#include <sstream>
+#include <string.h>
 
 cmXMLParser::cmXMLParser()
 {

Source/cmXMLParser.h

@@ -12,7 +12,9 @@
 #ifndef cmXMLParser_h
 #define cmXMLParser_h
 
-#include "cmStandardIncludes.h"
+#include <cmConfigure.h> // IWYU pragma: keep
+
+#include <string>
 
 extern "C" {
 void cmXMLParserStartElement(void*, const char*, const char**);

Source/cmXMLSafe.cxx

@@ -13,9 +13,7 @@
 
 #include "cm_utf8.h"
 
-#include <iostream>
 #include <sstream>
-
 #include <stdio.h>
 #include <string.h>
 

Source/cmXMLSafe.h

@@ -12,7 +12,7 @@
 #ifndef cmXMLSafe_h
 #define cmXMLSafe_h
 
-#include <cmsys/Configure.hxx>
+#include <cmConfigure.h> // IWYU pragma: keep
 
 #include <iosfwd>
 #include <string>

Source/cmXMLWriter.cxx

@@ -11,8 +11,6 @@
 ============================================================================*/
 #include "cmXMLWriter.h"
 
-#include "cmXMLSafe.h"
-
 #include <cassert>
 #include <cmsys/FStream.hxx>
 

Source/cmXMLWriter.h

@@ -12,7 +12,7 @@
 #ifndef cmXMLWiter_h
 #define cmXMLWiter_h
 
-#include "cmStandardIncludes.h"
+#include <cmConfigure.h> // IWYU pragma: keep
 
 #include "cmXMLSafe.h"
 

Source/cmcldeps.cxx

@@ -21,6 +21,7 @@
 #include <cmSystemTools.h>
 #include <cmsys/Encoding.hxx>
 
+#include <algorithm>
 #include <sstream>
 #include <windows.h>
 

Tests/CMakeLib/run_compile_commands.cxx

@@ -1,5 +1,13 @@
 #include "cmSystemTools.h"
 
+#include <fstream>
+#include <iostream>
+#include <map>
+#include <stdlib.h>
+#include <string>
+#include <utility>
+#include <vector>
+
 class CompileCommandParser
 {
 public:

Tests/CMakeLib/testSystemTools.cxx

@@ -11,6 +11,9 @@
 ============================================================================*/
 #include "cmSystemTools.h"
 
+#include <iostream>
+#include <string>
+
 #define cmPassed(m) std::cout << "Passed: " << m << "\n"
 #define cmFailed(m)                                                           \
   std::cout << "FAILED: " << m << "\n";                                       \