kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge branch 'fix-cmake_parse_arguments-expansion' into release

This commit is contained in:
Brad King 2016-02-12 11:25:36 -05:00
parent 2410a20ebb c8c45a2c4e
commit 229a5bc903
2 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Source/cmParseArgumentsCommand.cxx
View File

@ -97,10 +97,18 @@ bool cmParseArgumentsCommand
} insideValues = NONE;
std::string currentArgName;
// now iterate over the remaining arguments
// and fill in the values where applicable
// Flatten ;-lists in the arguments into a single list as was done
// by the original function(CMAKE_PARSE_ARGUMENTS).
list.clear();
for(; argIter != argEnd; ++argIter)
{
cmSystemTools::ExpandListArgument(*argIter, list);
}
// iterate over the arguments list and fill in the values where applicable
for (argIter = list.begin(), argEnd = list.end();
argIter != argEnd; ++argIter)
{
const options_map::iterator optIter = options.find(*argIter);
if (optIter != options.end())
{

19
Tests/RunCMake/cmake_parse_arguments/CornerCases.cmake
View File

@ -13,3 +13,22 @@ cmake_parse_arguments(MY_INSTALL "${options}" "${oneValueArgs}"
TEST(MY_INSTALL_DESTINATION UNDEFINED)
TEST(MY_INSTALL_OPTIONAL TRUE)
macro(foo)
set(_options )
set(_oneValueArgs FOO)
set(_multiValueArgs )
cmake_parse_arguments(_FOO2 "${_options}"
"${_oneValueArgs}"
"${_multiValueArgs}"
"${ARGN}")
cmake_parse_arguments(_FOO1 "${_options}"
"${_oneValueArgs}"
"${_multiValueArgs}"
${ARGN})
endmacro()
foo(FOO foo)
TEST(_FOO1_FOO foo)
TEST(_FOO2_FOO foo)