kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

COMP: Fix BOOL to bool conversion warning 

The cmSystemTools::RenameFile method returns type bool, but its
implementation on Windows returns the result of an API function that
returns BOOL.  This change avoids the compiler warning.
This commit is contained in:
Brad King 2009-04-15 11:00:03 -04:00
parent f3035ff78d
commit 1ed7f381f1
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/cmSystemTools.cxx
View File

@ -1139,18 +1139,18 @@ bool cmSystemTools::RenameFile(const char* oldname, const char* newname)
cannot quite rename the file atomically. Just delete the
destination and then move the file. */
DeleteFile(newname);
return MoveFile(oldname, newname);
return MoveFile(oldname, newname) != 0;
}
else
{
/* This is not Win9x. Use the MoveFileEx implementation. */
return MoveFileEx(oldname, newname, MOVEFILE_REPLACE_EXISTING);
return MoveFileEx(oldname, newname, MOVEFILE_REPLACE_EXISTING) != 0;
}
}
else
{
/* The destination does not exist. Just move the file. */
return MoveFile(oldname, newname);
return MoveFile(oldname, newname) != 0;
}
#else
/* On UNIX we have an OS-provided call to do this atomically. */