kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix find_* argument parsing crash (#11513) 

Previously the command

  find_path(VAR DOC "")

would crash because the argument pre-processing removed the DOC ""
arguments but the rest of the parsing assumes at least 2 arguments.
Reject the call with an error instead.
This commit is contained in:
Brad King 2010-11-30 08:39:16 -05:00
parent 63828762a0
commit 183d261b11
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Source/cmFindBase.cxx
View File

@ -164,6 +164,11 @@ bool cmFindBase::ParseArguments(std::vector<std::string> const& argsIn)
} }
} }
} }
if(args.size() < 2 )
{
this->SetError("called with incorrect number of arguments");
return false;
}
this->VariableName = args[0]; this->VariableName = args[0];
if(this->CheckForVariableInCache()) if(this->CheckForVariableInCache())
{ {