kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

VS: Always separate preprocessor defs by semicolon (#10902) 

Separation by ',' only works in VS 2008 and below and does not work in
the PlayStation3 VS plugin.  Separation by ';' works in VS 10 and all
prior versions.
This commit is contained in:
Brad King 2010-06-28 15:51:13 -04:00
parent a55aee5cdd
commit 13ca4ef665
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Source/cmVisualStudioGeneratorOptions.cxx
View File

@ -183,7 +183,7 @@ cmVisualStudioGeneratorOptions
{ {
fout << prefix << "PreprocessorDefinitions=\""; fout << prefix << "PreprocessorDefinitions=\"";
} }
const char* comma = ""; const char* sep = "";
for(std::vector<std::string>::const_iterator di = this->Defines.begin(); for(std::vector<std::string>::const_iterator di = this->Defines.begin();
di != this->Defines.end(); ++di) di != this->Defines.end(); ++di)
{ {
@ -208,15 +208,8 @@ cmVisualStudioGeneratorOptions
define = cmVisualStudioGeneratorOptionsEscapeForXML(define.c_str()); define = cmVisualStudioGeneratorOptionsEscapeForXML(define.c_str());
} }
// Store the flag in the project file. // Store the flag in the project file.
fout << comma << define; fout << sep << define;
if(this->Version == 10) sep = ";";
{
comma = ";";
}
else
{
comma = ",";
}
} }
if(this->Version == 10) if(this->Version == 10)
{ {