From 0bf093fd172951a8da7fc892da95c5c37a3354e2 Mon Sep 17 00:00:00 2001 From: Brad King Date: Mon, 18 Aug 2008 11:26:51 -0400 Subject: [PATCH] STYLE: Convert unused target type cases to default In switch statements that deal with only a few target types, use a 'default' case for the remaining target types instead of listing them explicitly. This will make it easier to add more types in the future. --- Source/cmLocalGenerator.cxx | 12 ++---------- Source/cmTarget.cxx | 18 +++--------------- 2 files changed, 5 insertions(+), 25 deletions(-) diff --git a/Source/cmLocalGenerator.cxx b/Source/cmLocalGenerator.cxx index 35e14ff11..064cfb5ac 100644 --- a/Source/cmLocalGenerator.cxx +++ b/Source/cmLocalGenerator.cxx @@ -723,11 +723,7 @@ void cmLocalGenerator } } break; - case cmTarget::UTILITY: - case cmTarget::GLOBAL_TARGET: - case cmTarget::INSTALL_FILES: - case cmTarget::INSTALL_PROGRAMS: - case cmTarget::INSTALL_DIRECTORY: + default: break; } } @@ -1441,11 +1437,7 @@ void cmLocalGenerator::GetTargetFlags(std::string& linkLibs, } } break; - case cmTarget::UTILITY: - case cmTarget::GLOBAL_TARGET: - case cmTarget::INSTALL_FILES: - case cmTarget::INSTALL_PROGRAMS: - case cmTarget::INSTALL_DIRECTORY: + default: break; } } diff --git a/Source/cmTarget.cxx b/Source/cmTarget.cxx index 7d49a0a2e..caa534f38 100644 --- a/Source/cmTarget.cxx +++ b/Source/cmTarget.cxx @@ -2043,11 +2043,7 @@ const char* cmTarget::GetCreateRuleVariable() return "_CREATE_SHARED_MODULE"; case cmTarget::EXECUTABLE: return "_LINK_EXECUTABLE"; - case cmTarget::UTILITY: - case cmTarget::GLOBAL_TARGET: - case cmTarget::INSTALL_FILES: - case cmTarget::INSTALL_PROGRAMS: - case cmTarget::INSTALL_DIRECTORY: + default: break; } return ""; @@ -2073,11 +2069,7 @@ const char* cmTarget::GetSuffixVariableInternal(TargetType type, return (implib ? "CMAKE_IMPORT_LIBRARY_SUFFIX" : "CMAKE_EXECUTABLE_SUFFIX"); - case cmTarget::UTILITY: - case cmTarget::GLOBAL_TARGET: - case cmTarget::INSTALL_FILES: - case cmTarget::INSTALL_PROGRAMS: - case cmTarget::INSTALL_DIRECTORY: + default: break; } return ""; @@ -2102,11 +2094,7 @@ const char* cmTarget::GetPrefixVariableInternal(TargetType type, : "CMAKE_SHARED_MODULE_PREFIX"); case cmTarget::EXECUTABLE: return (implib? "CMAKE_IMPORT_LIBRARY_PREFIX" : ""); - case cmTarget::UTILITY: - case cmTarget::GLOBAL_TARGET: - case cmTarget::INSTALL_FILES: - case cmTarget::INSTALL_PROGRAMS: - case cmTarget::INSTALL_DIRECTORY: + default: break; } return "";