ninja: use the minimum of all command line length limits (#14892)

When choosing whether to use a response file, consider several possible
command line length limits for the current operating system, and choose
the smallest.
This commit is contained in:
Ben Boeckel 2015-01-14 13:11:44 -05:00 committed by Brad King
parent 57622bd19d
commit 097e26f490
1 changed files with 22 additions and 7 deletions

View File

@ -22,6 +22,7 @@
#include <assert.h> #include <assert.h>
#include <algorithm> #include <algorithm>
#include <limits>
#ifndef _WIN32 #ifndef _WIN32
#include <unistd.h> #include <unistd.h>
@ -371,15 +372,29 @@ cmNinjaNormalTargetGenerator
static int calculateCommandLineLengthLimit(int linkRuleLength) static int calculateCommandLineLengthLimit(int linkRuleLength)
{ {
static int const limits[] = {
#ifdef _WIN32 #ifdef _WIN32
return 8000 - linkRuleLength; 8000,
#elif defined(__linux) || defined(__APPLE__) || defined(__HAIKU__)
// for instance ARG_MAX is 2096152 on Ubuntu or 262144 on Mac
return ((int)sysconf(_SC_ARG_MAX)) - linkRuleLength - 1000;
#else
(void)linkRuleLength;
return -1;
#endif #endif
#if defined(__APPLE__) || defined(__HAIKU__) || defined(__linux)
// for instance ARG_MAX is 2096152 on Ubuntu or 262144 on Mac
((int)sysconf(_SC_ARG_MAX)) - 1000,
#endif
#if defined(__linux)
// #define MAX_ARG_STRLEN (PAGE_SIZE * 32) in Linux's binfmts.h
((int)sysconf(_SC_PAGESIZE) * 32) - 1000,
#endif
std::numeric_limits<int>::max()
};
size_t const arrSz = cmArraySize(limits);
int const sz = *std::min_element(limits, limits + arrSz);
if (sz == std::numeric_limits<int>::max())
{
return -1;
}
return sz - linkRuleLength;
} }