338 lines
13 KiB
C
338 lines
13 KiB
C
|
/*-
|
||
|
|
* Copyright (c) 2003-2007 Tim Kientzle
|
||
|
|
* All rights reserved.
|
||
|
|
*
|
||
|
|
* Redistribution and use in source and binary forms, with or without
|
||
|
|
* modification, are permitted provided that the following conditions
|
||
|
|
* are met:
|
||
|
|
* 1. Redistributions of source code must retain the above copyright
|
||
|
|
* notice, this list of conditions and the following disclaimer.
|
||
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
||
|
|
* notice, this list of conditions and the following disclaimer in the
|
||
|
|
* documentation and/or other materials provided with the distribution.
|
||
|
|
*
|
||
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR(S) ``AS IS'' AND ANY EXPRESS OR
|
||
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
||
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
||
|
|
* IN NO EVENT SHALL THE AUTHOR(S) BE LIABLE FOR ANY DIRECT, INDIRECT,
|
||
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
||
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
||
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
||
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
||
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
||
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
||
|
|
*/
|
||
|
|
#include "test.h"
|
||
|
|
__FBSDID("$FreeBSD: src/lib/libarchive/test/test_pax_filename_encoding.c,v 1.3 2008/08/11 01:19:36 kientzle Exp $");
|
||
|
|
|
||
|
|
#include <locale.h>
|
||
|
|
|
||
|
|
/*
|
||
|
|
* Pax interchange is supposed to encode filenames into
|
||
|
|
* UTF-8. Of course, that's not always possible. This
|
||
|
|
* test is intended to verify that filenames always get
|
||
|
|
* stored and restored correctly, regardless of the encodings.
|
||
|
|
*/
|
||
|
|
|
||
|
|
/*
|
||
|
|
* Read a manually-created archive that has filenames that are
|
||
|
|
* stored in binary instead of UTF-8 and verify that we get
|
||
|
|
* the right filename returned and that we get a warning only
|
||
|
|
* if the header isn't marked as binary.
|
||
|
|
*/
|
||
|
|
static void
|
||
|
|
test_pax_filename_encoding_1(void)
|
||
|
|
{
|
||
|
|
static const char testname[] = "test_pax_filename_encoding.tar";
|
||
|
|
/*
|
||
|
|
* \314\214 is a valid 2-byte UTF-8 sequence.
|
||
|
|
* \374 is invalid in UTF-8.
|
||
|
|
*/
|
||
|
|
char filename[] = "abc\314\214mno\374xyz";
|
||
|
|
struct archive *a;
|
||
|
|
struct archive_entry *entry;
|
||
|
|
|
||
|
|
/*
|
||
|
|
* Read an archive that has non-UTF8 pax filenames in it.
|
||
|
|
*/
|
||
|
|
extract_reference_file(testname);
|
||
|
|
a = archive_read_new();
|
||
|
|
assertEqualInt(ARCHIVE_OK, archive_read_support_format_tar(a));
|
||
|
|
assertEqualInt(ARCHIVE_OK, archive_read_support_compression_all(a));
|
||
|
|
assertEqualInt(ARCHIVE_OK,
|
||
|
|
archive_read_open_filename(a, testname, 10240));
|
||
|
|
/*
|
||
|
|
* First entry in this test archive has an invalid UTF-8 sequence
|
||
|
|
* in it, but the header is not marked as hdrcharset=BINARY, so that
|
||
|
|
* requires a warning.
|
||
|
|
*/
|
||
|
|
failure("Invalid UTF8 in a pax archive pathname should cause a warning");
|
||
|
|
assertEqualInt(ARCHIVE_WARN, archive_read_next_header(a, &entry));
|
||
|
|
assertEqualString(filename, archive_entry_pathname(entry));
|
||
|
|
/*
|
||
|
|
* Second entry is identical except that it does have
|
||
|
|
* hdrcharset=BINARY, so no warning should be generated.
|
||
|
|
*/
|
||
|
|
failure("A pathname with hdrcharset=BINARY can have invalid UTF8\n"
|
||
|
|
" characters in it without generating a warning");
|
||
|
|
assertEqualInt(ARCHIVE_OK, archive_read_next_header(a, &entry));
|
||
|
|
assertEqualString(filename, archive_entry_pathname(entry));
|
||
|
|
archive_read_finish(a);
|
||
|
|
}
|
||
|
|
|
||
|
|
/*
|
||
|
|
* Set the locale and write a pathname containing invalid characters.
|
||
|
|
* This should work; the underlying implementation should automatically
|
||
|
|
* fall back to storing the pathname in binary.
|
||
|
|
*/
|
||
|
|
static void
|
||
|
|
test_pax_filename_encoding_2(void)
|
||
|
|
{
|
||
|
|
char filename[] = "abc\314\214mno\374xyz";
|
||
|
|
struct archive *a;
|
||
|
|
struct archive_entry *entry;
|
||
|
|
char buff[65536];
|
||
|
|
char longname[] = "abc\314\214mno\374xyz"
|
||
|
|
"/abc\314\214mno\374xyz/abcdefghijklmnopqrstuvwxyz"
|
||
|
|
"/abc\314\214mno\374xyz/abcdefghijklmnopqrstuvwxyz"
|
||
|
|
"/abc\314\214mno\374xyz/abcdefghijklmnopqrstuvwxyz"
|
||
|
|
"/abc\314\214mno\374xyz/abcdefghijklmnopqrstuvwxyz"
|
||
|
|
"/abc\314\214mno\374xyz/abcdefghijklmnopqrstuvwxyz"
|
||
|
|
"/abc\314\214mno\374xyz/abcdefghijklmnopqrstuvwxyz"
|
||
|
|
;
|
||
|
|
size_t used;
|
||
|
|
|
||
|
|
/*
|
||
|
|
* We need a starting locale which has invalid sequences.
|
||
|
|
* de_DE.UTF-8 seems to be commonly supported.
|
||
|
|
*/
|
||
|
|
/* If it doesn't exist, just warn and return. */
|
||
|
|
if (NULL == setlocale(LC_ALL, LOCALE_DE)) {
|
||
|
|
skipping("invalid encoding tests require a suitable locale;"
|
||
|
|
" %s not available on this system", LOCALE_DE);
|
||
|
|
return;
|
||
|
|
}
|
||
|
|
|
||
|
|
assert((a = archive_write_new()) != NULL);
|
||
|
|
assertEqualIntA(a, 0, archive_write_set_format_pax(a));
|
||
|
|
assertEqualIntA(a, 0, archive_write_set_compression_none(a));
|
||
|
|
assertEqualIntA(a, 0, archive_write_set_bytes_per_block(a, 0));
|
||
|
|
assertEqualInt(0,
|
||
|
|
archive_write_open_memory(a, buff, sizeof(buff), &used));
|
||
|
|
|
||
|
|
assert((entry = archive_entry_new()) != NULL);
|
||
|
|
/* Set pathname, gname, uname, hardlink to nonconvertible values. */
|
||
|
|
archive_entry_copy_pathname(entry, filename);
|
||
|
|
archive_entry_copy_gname(entry, filename);
|
||
|
|
archive_entry_copy_uname(entry, filename);
|
||
|
|
archive_entry_copy_hardlink(entry, filename);
|
||
|
|
archive_entry_set_filetype(entry, AE_IFREG);
|
||
|
|
failure("This should generate a warning for nonconvertible names.");
|
||
|
|
assertEqualInt(ARCHIVE_WARN, archive_write_header(a, entry));
|
||
|
|
archive_entry_free(entry);
|
||
|
|
|
||
|
|
assert((entry = archive_entry_new()) != NULL);
|
||
|
|
/* Set path, gname, uname, and symlink to nonconvertible values. */
|
||
|
|
archive_entry_copy_pathname(entry, filename);
|
||
|
|
archive_entry_copy_gname(entry, filename);
|
||
|
|
archive_entry_copy_uname(entry, filename);
|
||
|
|
archive_entry_copy_symlink(entry, filename);
|
||
|
|
archive_entry_set_filetype(entry, AE_IFLNK);
|
||
|
|
failure("This should generate a warning for nonconvertible names.");
|
||
|
|
assertEqualInt(ARCHIVE_WARN, archive_write_header(a, entry));
|
||
|
|
archive_entry_free(entry);
|
||
|
|
|
||
|
|
assert((entry = archive_entry_new()) != NULL);
|
||
|
|
/* Set pathname to a very long nonconvertible value. */
|
||
|
|
archive_entry_copy_pathname(entry, longname);
|
||
|
|
archive_entry_set_filetype(entry, AE_IFREG);
|
||
|
|
failure("This should generate a warning for nonconvertible names.");
|
||
|
|
assertEqualInt(ARCHIVE_WARN, archive_write_header(a, entry));
|
||
|
|
archive_entry_free(entry);
|
||
|
|
|
||
|
|
assertEqualInt(0, archive_write_close(a));
|
||
|
|
#if ARCHIVE_VERSION_NUMBER < 2000000
|
||
|
|
archive_write_finish(a);
|
||
|
|
#else
|
||
|
|
assertEqualInt(0, archive_write_finish(a));
|
||
|
|
#endif
|
||
|
|
|
||
|
|
/*
|
||
|
|
* Now read the entries back.
|
||
|
|
*/
|
||
|
|
|
||
|
|
assert((a = archive_read_new()) != NULL);
|
||
|
|
assertEqualInt(0, archive_read_support_format_tar(a));
|
||
|
|
assertEqualInt(0, archive_read_open_memory(a, buff, used));
|
||
|
|
|
||
|
|
assertEqualInt(0, archive_read_next_header(a, &entry));
|
||
|
|
assertEqualString(filename, archive_entry_pathname(entry));
|
||
|
|
assertEqualString(filename, archive_entry_gname(entry));
|
||
|
|
assertEqualString(filename, archive_entry_uname(entry));
|
||
|
|
assertEqualString(filename, archive_entry_hardlink(entry));
|
||
|
|
|
||
|
|
assertEqualInt(0, archive_read_next_header(a, &entry));
|
||
|
|
assertEqualString(filename, archive_entry_pathname(entry));
|
||
|
|
assertEqualString(filename, archive_entry_gname(entry));
|
||
|
|
assertEqualString(filename, archive_entry_uname(entry));
|
||
|
|
assertEqualString(filename, archive_entry_symlink(entry));
|
||
|
|
|
||
|
|
assertEqualInt(0, archive_read_next_header(a, &entry));
|
||
|
|
assertEqualString(longname, archive_entry_pathname(entry));
|
||
|
|
|
||
|
|
assertEqualInt(0, archive_read_close(a));
|
||
|
|
#if ARCHIVE_VERSION_NUMBER < 2000000
|
||
|
|
archive_read_finish(a);
|
||
|
|
#else
|
||
|
|
assertEqualInt(0, archive_read_finish(a));
|
||
|
|
#endif
|
||
|
|
}
|
||
|
|
|
||
|
|
/*
|
||
|
|
* Create an entry starting from a wide-character Unicode pathname,
|
||
|
|
* read it back into "C" locale, which doesn't support the name.
|
||
|
|
* TODO: Figure out the "right" behavior here.
|
||
|
|
*/
|
||
|
|
static void
|
||
|
|
test_pax_filename_encoding_3(void)
|
||
|
|
{
|
||
|
|
wchar_t badname[] = L"xxxAyyyBzzz";
|
||
|
|
const char badname_utf8[] = "xxx\xE1\x88\xB4yyy\xE5\x99\xB8zzz";
|
||
|
|
struct archive *a;
|
||
|
|
struct archive_entry *entry;
|
||
|
|
char buff[65536];
|
||
|
|
size_t used;
|
||
|
|
|
||
|
|
badname[3] = 0x1234;
|
||
|
|
badname[7] = 0x5678;
|
||
|
|
|
||
|
|
/* If it doesn't exist, just warn and return. */
|
||
|
|
if (NULL == setlocale(LC_ALL, "C")) {
|
||
|
|
skipping("Can't set \"C\" locale, so can't exercise "
|
||
|
|
"certain character-conversion failures");
|
||
|
|
return;
|
||
|
|
}
|
||
|
|
|
||
|
|
/* If wctomb is broken, warn and return. */
|
||
|
|
if (wctomb(buff, 0x1234) > 0) {
|
||
|
|
skipping("Cannot test conversion failures because \"C\" "
|
||
|
|
"locale on this system has no invalid characters.");
|
||
|
|
return;
|
||
|
|
}
|
||
|
|
|
||
|
|
/* If wctomb is broken, warn and return. */
|
||
|
|
if (wctomb(buff, 0x1234) > 0) {
|
||
|
|
skipping("Cannot test conversion failures because \"C\" "
|
||
|
|
"locale on this system has no invalid characters.");
|
||
|
|
return;
|
||
|
|
}
|
||
|
|
|
||
|
|
assert((a = archive_write_new()) != NULL);
|
||
|
|
assertEqualIntA(a, 0, archive_write_set_format_pax(a));
|
||
|
|
assertEqualIntA(a, 0, archive_write_set_compression_none(a));
|
||
|
|
assertEqualIntA(a, 0, archive_write_set_bytes_per_block(a, 0));
|
||
|
|
assertEqualInt(0,
|
||
|
|
archive_write_open_memory(a, buff, sizeof(buff), &used));
|
||
|
|
|
||
|
|
assert((entry = archive_entry_new()) != NULL);
|
||
|
|
/* Set pathname to non-convertible wide value. */
|
||
|
|
archive_entry_copy_pathname_w(entry, badname);
|
||
|
|
archive_entry_set_filetype(entry, AE_IFREG);
|
||
|
|
assertEqualInt(ARCHIVE_OK, archive_write_header(a, entry));
|
||
|
|
archive_entry_free(entry);
|
||
|
|
|
||
|
|
assert((entry = archive_entry_new()) != NULL);
|
||
|
|
archive_entry_copy_pathname_w(entry, L"abc");
|
||
|
|
/* Set gname to non-convertible wide value. */
|
||
|
|
archive_entry_copy_gname_w(entry, badname);
|
||
|
|
archive_entry_set_filetype(entry, AE_IFREG);
|
||
|
|
assertEqualInt(ARCHIVE_OK, archive_write_header(a, entry));
|
||
|
|
archive_entry_free(entry);
|
||
|
|
|
||
|
|
assert((entry = archive_entry_new()) != NULL);
|
||
|
|
archive_entry_copy_pathname_w(entry, L"abc");
|
||
|
|
/* Set uname to non-convertible wide value. */
|
||
|
|
archive_entry_copy_uname_w(entry, badname);
|
||
|
|
archive_entry_set_filetype(entry, AE_IFREG);
|
||
|
|
assertEqualInt(ARCHIVE_OK, archive_write_header(a, entry));
|
||
|
|
archive_entry_free(entry);
|
||
|
|
|
||
|
|
assert((entry = archive_entry_new()) != NULL);
|
||
|
|
archive_entry_copy_pathname_w(entry, L"abc");
|
||
|
|
/* Set hardlink to non-convertible wide value. */
|
||
|
|
archive_entry_copy_hardlink_w(entry, badname);
|
||
|
|
archive_entry_set_filetype(entry, AE_IFREG);
|
||
|
|
assertEqualInt(ARCHIVE_OK, archive_write_header(a, entry));
|
||
|
|
archive_entry_free(entry);
|
||
|
|
|
||
|
|
assert((entry = archive_entry_new()) != NULL);
|
||
|
|
archive_entry_copy_pathname_w(entry, L"abc");
|
||
|
|
/* Set symlink to non-convertible wide value. */
|
||
|
|
archive_entry_copy_symlink_w(entry, badname);
|
||
|
|
archive_entry_set_filetype(entry, AE_IFLNK);
|
||
|
|
assertEqualInt(ARCHIVE_OK, archive_write_header(a, entry));
|
||
|
|
archive_entry_free(entry);
|
||
|
|
|
||
|
|
assertEqualInt(0, archive_write_close(a));
|
||
|
|
#if ARCHIVE_VERSION_NUMBER < 2000000
|
||
|
|
archive_write_finish(a);
|
||
|
|
#else
|
||
|
|
assertEqualInt(0, archive_write_finish(a));
|
||
|
|
#endif
|
||
|
|
|
||
|
|
/*
|
||
|
|
* Now read the entries back.
|
||
|
|
*/
|
||
|
|
|
||
|
|
assert((a = archive_read_new()) != NULL);
|
||
|
|
assertEqualInt(0, archive_read_support_format_tar(a));
|
||
|
|
assertEqualInt(0, archive_read_open_memory(a, buff, used));
|
||
|
|
|
||
|
|
failure("A non-convertible pathname should cause a warning.");
|
||
|
|
assertEqualInt(ARCHIVE_WARN, archive_read_next_header(a, &entry));
|
||
|
|
assertEqualWString(badname, archive_entry_pathname_w(entry));
|
||
|
|
failure("If native locale can't convert, we should get UTF-8 back.");
|
||
|
|
assertEqualString(badname_utf8, archive_entry_pathname(entry));
|
||
|
|
|
||
|
|
failure("A non-convertible gname should cause a warning.");
|
||
|
|
assertEqualInt(ARCHIVE_WARN, archive_read_next_header(a, &entry));
|
||
|
|
assertEqualWString(badname, archive_entry_gname_w(entry));
|
||
|
|
failure("If native locale can't convert, we should get UTF-8 back.");
|
||
|
|
assertEqualString(badname_utf8, archive_entry_gname(entry));
|
||
|
|
|
||
|
|
failure("A non-convertible uname should cause a warning.");
|
||
|
|
assertEqualInt(ARCHIVE_WARN, archive_read_next_header(a, &entry));
|
||
|
|
assertEqualWString(badname, archive_entry_uname_w(entry));
|
||
|
|
failure("If native locale can't convert, we should get UTF-8 back.");
|
||
|
|
assertEqualString(badname_utf8, archive_entry_uname(entry));
|
||
|
|
|
||
|
|
failure("A non-convertible hardlink should cause a warning.");
|
||
|
|
assertEqualInt(ARCHIVE_WARN, archive_read_next_header(a, &entry));
|
||
|
|
assertEqualWString(badname, archive_entry_hardlink_w(entry));
|
||
|
|
failure("If native locale can't convert, we should get UTF-8 back.");
|
||
|
|
assertEqualString(badname_utf8, archive_entry_hardlink(entry));
|
||
|
|
|
||
|
|
failure("A non-convertible symlink should cause a warning.");
|
||
|
|
assertEqualInt(ARCHIVE_WARN, archive_read_next_header(a, &entry));
|
||
|
|
assertEqualWString(badname, archive_entry_symlink_w(entry));
|
||
|
|
assertEqualWString(NULL, archive_entry_hardlink_w(entry));
|
||
|
|
failure("If native locale can't convert, we should get UTF-8 back.");
|
||
|
|
assertEqualString(badname_utf8, archive_entry_symlink(entry));
|
||
|
|
|
||
|
|
assertEqualInt(ARCHIVE_EOF, archive_read_next_header(a, &entry));
|
||
|
|
|
||
|
|
assertEqualInt(0, archive_read_close(a));
|
||
|
|
#if ARCHIVE_VERSION_NUMBER < 2000000
|
||
|
|
archive_read_finish(a);
|
||
|
|
#else
|
||
|
|
assertEqualInt(0, archive_read_finish(a));
|
||
|
|
#endif
|
||
|
|
}
|
||
|
|
|
||
|
|
DEFINE_TEST(test_pax_filename_encoding)
|
||
|
|
{
|
||
|
|
test_pax_filename_encoding_1();
|
||
|
|
test_pax_filename_encoding_2();
|
||
|
|
test_pax_filename_encoding_3();
|
||
|
|
}
|